FIX: Корректное обновление updatedOn для Comment при редактировании #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gagarskiy-Andrey
approved these changes
Jun 1, 2025
SergikF
approved these changes
Jun 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Данный Pull Request исправляет ошибку, при которой поле
updatedOnв сущностиCommentне обновлялось корректно при редактировании, если изменения не были немедленно синхронизированы с базой данных перед возвратом сущности из сервисного метода.Проблема:
Механизм JPA Auditing (
@LastModifiedDate) обновляет полеupdatedOnво время операцииflush. Еслиflushне вызывался явно после изменения сущностиCommentи перед ее маппингом в DTO, возвращаемый DTO мог содержатьupdatedOn, равныйcreatedOn.Реализованные изменения:
CommentServiceImpl.updateUserCommentвызовcommentRepository.save(existedComment)заменен наcommentRepository.saveAndFlush(existedComment).AuditingEntityListenerобновит полеupdatedOnдо того, как измененная сущность будет использована для формирования ответа DTO.